Skip to content
This repository has been archived by the owner on Sep 12, 2024. It is now read-only.

hook to close all stopped campaigns #483

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

vlimant
Copy link
Contributor

@vlimant vlimant commented Jan 29, 2020

so as to remove the man in the middle, unified can look in mcm and disable all stopped campaigns

before merging, one needs to uncomment (and test) the update_one command

@sharad1126
Copy link
Contributor

We already have a policy to close the campaigns. We have the script remove_campaigns to remove it from the dB, and copy it into archive json file.

@vlimant
Copy link
Contributor Author

vlimant commented Jan 29, 2020

that still requires a human in the loop. this PR removes the ops-human

@sharad1126
Copy link
Contributor

sharad1126 commented Jan 30, 2020

I went through the code and this will cause the same issue i.e. not removing the campaign from the json file. Therefore, the last time we discussed about this, we made the remove_campaigns.py which actually removes the campaign from the mongodb and copies it to the archive json file so operator doesn't has to see those campaigns in the campaigns.json file. I do understand the idea of automation behind this so no manual updates and all is needed. may be we can modify this a bit more and use it to remove the config from campaigns.json->archive_campaigns.json(using the code we have in remove_campaigns.py)

@vlimant
Copy link
Contributor Author

vlimant commented Mar 12, 2020

it could be as easy as dumping only go=true campaigns in campaigns.json and the go=false in archive_campaigns.json, or add an "archive" field somewhere (although as I said in the first place, there is no need for the archive file, and despite my comments and arguments it was put in place, barring the way to deployement of this automatic procedure. FYI @drkovalskyi ) there is no justification to increasing human intervention, when actually people claim they have too much on their hands

@sharad1126
Copy link
Contributor

During operations, I felt it to be too much to go through campaigns in campaigns.json even if the campaigns aren't used so I worked with @optimisticcynic who agreed with this for managing campaigns. I leave it on the L3s (@jenimal @z4027163) and @scarletnorberg as she will be the one who will be handling campaigns after @optimisticcynic leaves.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants